Looks good Drew :) Thanks,
Darren On 22/04/2011 15:50, Drew Fisher wrote: > Good morning, > > I just need a quick code review for > > http://monaco.sfbay.sun.com/detail.jsf?cr=7038870 > > Here's the entire fix: > > diff -r 6ac92c9d29e0 usr/src/lib/install_target/physical.py > --- a/usr/src/lib/install_target/physical.py Thu Apr 21 23:16:03 2011 -0600 > +++ b/usr/src/lib/install_target/physical.py Fri Apr 22 08:17:02 2011 -0600 > @@ -663,7 +663,7 @@ > """ > # check the index value. If the partition to be created is a > logical > # partition, set the bootid to Partition.INACTIVE per fdisk rules > - if index> const.FD_NUMPART: > + if int(index)> const.FD_NUMPART: > bootid = Partition.INACTIVE > > > > Thanks! > > -Drew > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

