On 28/04/2011 16:47, Drew Fisher wrote: > Darren, > > I would need to test this out to confirm, but I'm pretty sure everything > works as it should: > > - User has a disk with windows/linux installed already. > - User boots a liveCD. > - User uses something like gparted to edit the partition table and > creates a new partition for the solaris install. > - TD runs and finds both partitions. Marks them both as "preserve" (the > default) > - The installer runs select_disk() from the Target Controller. (or > whichever function is right - I don't know TC that well) > - TC sets up the correct slice information in the gparted-created > solaris partition > - TI runs and sees a "preserve" action on the new solaris partition and > nothing happens. sees a "create" action on slice 0 so it creates the > needed slices in the partition > - The installer continues and the user has a fantastic installation > experience. > > Does this sound right to you?
Sounds about right yeah apart from the "use gparted to create Solaris partition" one, that one shouldn't really be necessary ;) I know QE will check this one anyway, but no harm to ask... Thanks, Darren. > > -Drew > > > > > > > On 4/28/11 9:37 AM, Darren Kenny wrote: >> The change looks good, but can you confirm that this doesn't impact a >> partition >> that already exists on the disk negatively. >> >> Specifically, if you have a partition that is functional with a >> start_sector=0, >> for Windows or Linux, will this remain unchanged in the fdisk table written, >> if >> preserve is set as the action? >> >> Thanks, >> >> Darren. >> >> On 28/04/2011 16:22, Drew Fisher wrote: >>> Good morning, >>> >>> Could I get a quick code review for: >>> >>> 7040308<http://monaco.us.oracle.com/detail.jsf?cr=7040308> Target cylinder >>> boundary adjustments are made in wrong order >>> >>> >>> http://cr.opensolaris.org/~drewfish/cr_7040308/ >>> >>> Target unittests run fine with the change. >>> >>> Thanks! >>> >>> -Drew >>> >>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
