Jack,
On 4/28/11 3:13 PM, Jack Schwartz wrote:
Hi Drew.
Here are my comments...
On 04/28/11 12:45 PM, Drew Fisher wrote:
Good afternoon!
Here's my second take at this. I went through Brock's code changes
and updated our gate accordingly.
http://cr.opensolaris.org/~drewfish/cr_7039499/
I tested this by building full ISOs on x86. All 3 ISOs build
correctly, boot up and start installation correctly.
Bug's suggested fix needs to be updated.
Fixed.
I also grabbed and fixed
7040051 <http://monaco.us.oracle.com/detail.jsf?cr=7040051> Unit test
failure in test_p5i.py even after 7013385
<http://monaco.us.oracle.com/detail.jsf?cr=7013385> is fixed.
At the same time.
According to my understanding of this bug report's evaluation, if
Publisher() gets no args it will bomb.
A search through slim_source reveals many more places where
Publisher() is called without args, that the code review shows are
fixed. Are these all supposed to get no args (as for testing bogus
conditions, etc)?
Files I saw include:
./lib/install_transfer/test/test_ips.py (1)
- This is inside a method called test_default_publisher(), which makes
me wonder whether calling Publisher here without args is OK and that
it takes a default?
TransferIPS will set a default publisher if you don't specify one.
TransferP5I will not. This is why I had to label the publisher for the
test.
./lib/install_transfer/test/test_svr4.py (many)
This file's contents look suspicious. (But is this file on the way
out as it's SVR4?)
The svr4 code wasn't touched. I think Jean recycled the same names for
these tests.
Are these all supposed to get no args (as for testing bogus
conditions, etc)?
I think the rest of the tests cover this.
Also, all transfer tests run successfully, even the ones I didn't touch. :)
Thanks for looking, Jack.
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
