HI Karen. Thanks for reviewing.
Jack
On 04/29/11 10:22 AM, Karen Tung wrote:
Hi Jack,As requested by you, I reviewed the makefile related changes in the following files:usr/src/cmd/Makefile usr/src/cmd/ai-webserver/README.test usr/src/lib/Makefile usr/src/lib/Makefile.targ usr/src/pkg/manifests/system-install-auto-install.mf usr/src/tools/tests/tests.nose They look good to me. Thanks, --Karen* *On 04/28/11 13:35, Jack Schwartz wrote:Hi everyone.Here is a relatively simple code review for some Derived Manifest project bugfixes.Bugs fixed are:7038729 <http://monaco.us.oracle.com/detail.jsf?cr=7038729> Older default.xml manifests need to be importedinto new default manifest handling7039251 <http://monaco.us.oracle.com/detail.jsf?cr=7039251> Unit testing improvements for Derived Manifests 7040405 <http://monaco.us.oracle.com/detail.jsf?cr=7040405> Manifest Input Module add() needs to alwaysinsert new elements after other siblings with same tag7040451 <http://monaco.us.oracle.com/detail.jsf?cr=7040451> Make slim_source soaktime more meaningful forManifest Input Module as it waits for CUD-AIIt addresses upgrade issues of default manifests, improved unit tests, availability of modules, and a small Manifest Input module bugfixCode review is at: http://cr.opensolaris.org/~schwartz/110428.1/webrev/index.html Bug reports are all up to date. All is ready to go!Please review sometime today or early tomorrow (before 10 AM PST) as I would like to integrate these into 165.Testing: Upgrade: - Verified on both old port-number and new servicename /var/ai directory formats - Restarted the system/install/server:default service after upgrade to be sure there were no issues. - Verified handling when default.xml or directory is missing. Unit tests: - Verified the automated ones work with slim_test. - Verified the manual one works. MIM: - Verified using test case in the bug report. - Verified with and without differently-tagged children following the element being added. Other: - Verified gate build, proto area, and packages. Thanks, Jack _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
