Good evening.
I need to get a code review for the following bugs:
7040795 <http://monaco.us.oracle.com/detail.jsf?cr=7040795> install
fails with setting preferred publisher errors after fix for 7039499
<http://monaco.us.oracle.com/detail.jsf?cr=7039499> is integrated
7040909 <http://monaco.us.oracle.com/detail.jsf?cr=7040909> install set
the wrong default publisher after fix for 7039499
<http://monaco.us.oracle.com/detail.jsf?cr=7039499> is integrated for
all installs.
http://cr.opensolaris.org/~drewfish/cr_7040795/
Evan already looked at my previous code review for 7040795. I can also
confirm that Mary tested the ISOs I generated and found the change to
the ICT code works. I'd like another pair of eyes on the fix, if possible.
For 7040909, we ran into a similar issue with the new IPS API. The
concept of a 'preferred' publisher is gone. The code that handled these
settings needed to be streamlined to handle this removal.
For testing, I used DC and the set-ips-attributes checkpoint to change
the publisher(s) after installation. I manually verified the publishers
(via pkg -R /<DC build dataset>/build_data/pkg_image publisher) to
ensure they were updating correctly. There is no need to construct and
test an entire ISO as the pkg5 CLI allows us to test the publishers in
the resulting dataset very easily.
I tested a very large matrix of publishers, mirrors and multiple origins
to ensure everything was set correctly. All tests pass and the
resulting publishers are set correctly.
I also ran all of the transfer unittests and made sure ips.py was pep8
clean.
-----
Test Matrix:
(each entry has a 'publisher / uri' string)
'solaris' publishers:
ipkg = http://ipkg.us.oracle.com/solaris11/dev
ib = http://indiana-build.us.oracle.com:8000
'install-nightly' publishers:
file = file:///export/home/drew/packages/i386/nightly-nd/repo.redist/
'pkg5-nightly' publishers:
pkg5 = http://ipkg.us.oracle.com/internall/solaris11/pkg/nightly
"install" - publishers set for 'transfer-ips-install' checkpoint
"set" - publishers set for 'set-ips-attributes' checkpoint
any asterisk character meant a mirror
----
install: solaris / ipkg
set: solaris / ipkg
install: solaris / ipkg
set: solaris / ib
install: solaris / ipkg, *i-b
set: solaris / ipkg
install: solaris/ ipkg
set solaris / ipkg, *i-b
install: solaris / ipkg, pkg5-nightly / ipkg, install-nightly / file:///
set solaris / ipkg
install: solaris / ipkg, pkg5-nightly / ipkg, install-nightly / file:///
set solaris / i-b
install: solaris / ipkg, pkg5-nightly / ipkg, install-nightly / file:///
set solaris / i-b, *ipkg
install: install-nightly / file:///, solaris / ipkg
set pkg5-nightly
install: install-nightly / file:///, solaris / ipkg
set solaris / ipkg
install: install-nightly / file:///, solaris / ipkg
set solaris / ib
Whew.
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
