Re: [caiman-discuss] Code review request for 7013796

Keith Mitchell Wed, 04 May 2011 09:05:52 -0700

Hi Nirmal,

The CR says that the total timeout should be around 10 minutes. Since TIMEOUT and TRIES on lines 54-55 are unchanged, it looks like it will still end up with 900 sec (15 min) timeouts, and attempting them 20 times, for a total of 5 hours of waiting if the file can't be retrieved.

I imagine the value for TIMEOUT should be closer to 60 seconds, and maybe the parameter to wget should be --read-timeout, not an overall --timeout (--connect-timeout may be valuable to set as well). TRIES can be 20 still, though maybe 10 is sufficient.

- Keith

On 05/ 4/11 05:40 AM, Nirmal Agarwal wrote:

Hi all

Please do a code review of the change for:

7013796 AI shouldn't have a 10 hour timeout when wget'ing files.

Webrev Location :

http://cr.opensolaris.org/~nirmal27/CR7013796/

I have created image using dc and tested it. It works fine.

Thanks,
Nirmal
--
Sun, an Oracle Company
Nirmal Agarwal
Solaris Install Group
Revenue Product Engineering (RPE), Systems 
|Bangalore |
Oracle is committed to developing practices and products that help protect the environment
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Re: [caiman-discuss] Code review request for 7013796

Reply via email to