Matt, Dave,

If you are talking about modifying the DTD to make <software_data>
a mandatory sub-element of <software> (and/or also making <name> a
mandatory sub-element of <software_data>) then I don't
think that will do what you are intending.

You would still need to ensure that at least one of the <software_data>
elements had the "install" action, right? And there is no way to enforce
that kind of check via DTD.  So, I think that all of this validation needs to
be done as part of "semantic validation" within the code.

Also, you will need to check wherever else <software> objects are used,
other than AI manifests and ensure that you are not breaking anything
there (off-hand I cannot think of anything that would break).

- dermot




On 05/04/11 17:40, Matt Keenan wrote:
On 05/ 4/11 05:01 PM, Dave Miner wrote:
On 05/ 4/11 06:38 AM, Matt Keenan wrote:
Hi

Came across a DTD issue, and would like some input.

In an AI manifest <software_data> element is optional and whether it
contains a list of packages is also optional, in AI what should happen
in this context.

Currently in cud_ai, this results in no actual IPS packages getting
installed at all.

What is the corrective action here :

1 - Make software_data a requirement of software ? and also make it a
requirement to contain a list of packages/consolidations to
install/uninstall ?

or

2 - If software_data is empty or not provided at all within a software
element then by default install what's specified in default.xml :
<name>pkg:/entire</name>
<name>pkg:/babel_install</name>

What would happen if action is "uninstall", not an issue I suppose
as it will simply uninstall nothing, and should not cause a failure.


The list of default packages to install really should be stored in a
central location, rather than being hard coded into auto_install.py, any
ideas where ?


#2 is not what we really want.  Is there a downside to making software_data a 
required element?


To go that route you'd need to make both <software_data> required and <name> 
elements within
<software_data> required also.

As for downside, I've no idea... kind of makes sense to me.

cheers

Matt

Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to