Hi Ginnie,
Thanks for the code review. Please see my responses inline.
On 04/27/11 09:51 AM, Virginia Wray wrote:
HI Karen --
I looked at Group 4:
ginnie
--------------------------------------
usr/src/cmd/slim-install/svc/net-assembly -ok
--------------------------------------
usr/src/Makefile.master
Put entry above transfer to order it correctly.
Fixed.
--------------------------------------
usr/src/Targetdirs -ok
-------------------------------------
usr/src/cmd/Makefile.targ -ok
--------------------------------------
usr/src/cmd/system-config/xslt/doc2sc_profile.xslt
ln 26 - varies/various
Hmm..I don't see this word in this file.
-------------------------------------
usr/src/lib/install_ict/__init__.py
I know the API version is changing to 57, so it will
need to be updated before you putback.
Yep. Actually, Drew already fixed it to have the latest.
Changes in this file won't be putback.
-------------------------------------
usr/src/lib/install_manifest/dtd/Makefile -ok
usr/src/lib/install_manifest/dtd/media-transfer.dtd -ok
usr/src/lib/install_transfer/Makefile -ok
usr/src/lib/install_transfer/cpio.py -ok
--------------------------------------
usr/src/lib/install_transfer/media_transfer.py
ln 71 - This sentence needs to be restructured
I changed it to:
The following SMF services are examined:
svc:/system/filesystem/root-assembly:net
svc:/system/filesystem/root-assembly:media
ln 202 - Don't need the return
Fixed.
ln 296 - prtconf should be a variable
Fixed.
ln 327 - dhcpinfo should be a variable
fixed.
ln 361 - there is some commented out code
removed.
---------------------------------------
usr/src/pkg/manifests/install-distribution-constructor.mf -ok
usr/src/pkg/manifests/system-install-text-install.mf -ok
usr/src/pkg/manifests/system-library-install.mf
move ln 266 above software to order correctly
Fixed.
Thanks for taking the time to review again.
--Karen
On 04/26/11 02:38 PM, Karen Tung wrote:
Hi everyone,
I am looking for reviewers for changes that move
the Text Installer to the CUD architecture.
I divided up the changes into the following 4 groups.
I would like to get at least 1 person looking at each group.
Please email me privately and let me know which group
you like to review.
I don't think a code walk through is needed, but if you think
having one will be useful, please let me know and I can set one
up on Thurs. AM.
The webrev is at:
http://cr.opensolaris.org/~ktung/text-to-cud/
Please provide me your comments as soon as possible.
I am more than happy to get multiple sets of comments as
you go through the code.
I would like to get most of your comments by COB next Monday, 5/2/2011.
Group 1: DC related changes
----------------------------
usr/src/cmd/distro_const/checkpoints/Makefile
usr/src/cmd/distro_const/checkpoints/boot_archive_configure.py
usr/src/cmd/distro_const/checkpoints/pkg_img_mod.py
usr/src/cmd/distro_const/checkpoints/xslt/Makefile
usr/src/cmd/distro_const/checkpoints/xslt/doc2_media_transfer.xslt
Group 2: Text Installer UI changes
-----------------------------------
usr/src/cmd/text-install/solaris_install/__init__.py
usr/src/cmd/text-install/solaris_install/disk_selection.py
usr/src/cmd/text-install/solaris_install/disk_window.py
usr/src/cmd/text-install/solaris_install/fdisk_partitions.py
usr/src/cmd/text-install/solaris_install/install_progress.py
usr/src/cmd/text-install/solaris_install/install_status.py
usr/src/cmd/text-install/solaris_install/log_viewer.py
usr/src/cmd/text-install/solaris_install/partition_edit_screen.py
usr/src/cmd/text-install/solaris_install/progress.py
usr/src/cmd/text-install/solaris_install/summary.py
usr/src/cmd/text-install/solaris_install/text-install
usr/src/cmd/text-install/solaris_install/ti_target_utils.py
usr/src/cmd/text-install/solaris_install/welcome.py
Group 3: Text Installer non-UI changes
--------------------------------------
usr/src/cmd/text-install/Makefile
usr/src/cmd/text-install/solaris_install/Makefile
usr/src/cmd/text-install/solaris_install/ti_install.py
usr/src/cmd/text-install/solaris_install/ti_install_utils.py
Group 4: Other changes
--------------------------------------
usr/src/cmd/slim-install/svc/net-assembly
usr/src/Makefile.master
usr/src/Targetdirs
usr/src/cmd/Makefile.targ
usr/src/cmd/system-config/xslt/doc2sc_profile.xslt
usr/src/lib/install_ict/__init__.py
usr/src/lib/install_manifest/dtd/Makefile
usr/src/lib/install_manifest/dtd/media-transfer.dtd
usr/src/lib/install_transfer/Makefile
usr/src/lib/install_transfer/cpio.py
usr/src/lib/install_transfer/media_transfer.py
usr/src/pkg/manifests/install-distribution-constructor.mf
usr/src/pkg/manifests/system-install-text-install.mf
usr/src/pkg/manifests/system-library-install.mf
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
