I should hope so. It's your suggested fix!
Thanks, Matt :)
-Drew
On 5/17/11 6:52 AM, Matt Keenan wrote:
LGTM.
thanks
Matt
On 05/17/11 01:51 PM, Drew Fisher wrote:
Good morning!
Could I get a fast code review for 7045566?
http://monaco.sfbay.sun.com/detail.jsf?cr=7045566
I've simply in-lined the pdiffs since it's a pretty simple fix.
We're just moving the output from the screen to the log.
Thanks!
-Drew
diff -r a401bf4396fc usr/src/lib/install_target/discovery.py
--- a/usr/src/lib/install_target/discovery.py Tue May 17 06:40:11
2011 -0600
+++ b/usr/src/lib/install_target/discovery.py Tue May 17 06:45:50
2011 -0600
@@ -29,6 +29,7 @@
information.
"""
+import logging
import os.path
import platform
import re
@@ -208,7 +209,8 @@
cmd = [FSTYP, slc.name]
p = Popen.check_call(cmd, stdout=Popen.STORE,
stderr=Popen.STORE,
logger=ILN,
- check_result=Popen.ANY)
+ check_result=Popen.ANY,
+
stderr_loglevel=logging.DEBUG)
if p.returncode == 0:
if p.stdout.strip() == "zfs":
# add the slice since it's used by zfs
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
