Hi Keith.
One residual issue from me... other items are resolved...
On 05/16/11 02:55 PM, Keith Mitchell wrote:
> usr/src/cmd/installadm/list.py
> ---------------------------------------
> 777: Please either add an "else: raise Exception" for the case
where the dbtable
> is not a profile or manifest table (preferred), or else change the
elif on 764
> to an else.
I'm not saying that's not a bad idea, but that's not from ISIM. It's a
programming error if it occurs, and the blanket "except StandardError"
wrapping the whole block makes it the raising of an exception at that
point interesting, but it should be enough to catch programming errors
in the future.
I didnt' quite follow... I get that it's a programming error if dbtable
isn't either a profiles table or manifests table, so I suggest that
either the elif on 764 is unnecessary (since the program is correct only
with one of these two tables anyway) or else flag the condition that a
different table was provided. IMO the best of these two is to change
the elif to an else and add a comment taht a profile table is expected
at that spot in the code.
Thanks,
Jack
- Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
