On 05/27/11 12:46, Drew Fisher wrote:
Good afternoon!
Could I please get a code review for:
7048838 <http://monaco.us.oracle.com/detail.jsf?cr=7048838> update
CLIENT_API_VERSION and remove 'recursive_removal' from install libraries
http://cr.opensolaris.org/~drewfish/cr_7048838/
Tested the changes with the unittests and I ran DC to make sure things
get removed correctly.
You should always check the return value of the plan_*() functions.
If they return False, that means the package system thinks there is
nothing to do.
If they return False, and you call prepare() anyway, you're going to get
a traceback from the pkg API.
Since this code wasn't doing that before, you're no worse off than
before, but a bug should be filed to fix that. (Likely at the same time
you switch from plan_*() to gen_plan_*()).
-Shawn
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
