William:
Thank you for fixing the test. Since you are touching ipaddress.py, can
you fix the following pep8 error:
/usr/lib/python2.6/vendor-packages/solaris_install/sysconfig/profile/ip_address.py:33:1:
E303 too many blank lines (3)
class IPAddress(object):
^
On 06/ 2/11 07:22 AM, William Schumann wrote:
Darren, Matt,
Eventually, this might be passed a value of None, so added check and
comment.
Tested UI, pyunit tested, resubmitted webrev.
Thank you,
William
On 06/ 2/11 01:08 PM, Darren Kenny wrote:
Looks good to me William.
Only one minor nit, in ip_address.py, is it possible for the address
to be a
None value? So should we test for it?
Thanks,
Darren.
On 02/06/2011 11:58, William Schumann wrote:
Requesting code review for minor issues in failed unit tests.
http://cr.opensolaris.org/~wmsch/bug-7050702/
Thank you,
William
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
