On 06/ 2/11 03:28 PM, Jack Schwartz wrote:
Hi everyone.
Here is a webrev of the installadm manpage changes relevant to the Derived
Manifests project.
Changes to installadm.1m also include some quick reformatting (so the manpage
prints better). However, reformatting is not complete since Sue will be doing an
overhaul with the ISIM project soon.
Once it is reviewed, I will push it to slim_source.
Also included, as an extra bonus :) is the aimanifest manpage. This still in
progress but I'm close to being done with it. Please have a look and let me know
if you have comments. I plan on giving this to Alta to work her magic on it
before pushing it to the gate, since I'm the only one working on it.
http://cr.opensolaris.org/~schwartz/110602.1/webrev/index.html
Please submit any comments by Tuesday 6/7 COB.
Thanks for your time,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Jack,
I just looked at the installadm man page.
General: all references to "install service" should say "installation service"
16 Remove '...'
29 Change:
<manifest/script_file> -> <manifest/script file>
or
<manifest/script_file> -> <manifest_file/script_file>
(to get across the idea that the manifest is a file)
35 Please add --options, such as -n|--service <svcname>.
This would apply to the other commands, but as I've already added them in the
isim gate, you don't really need to do it here.
64 Need to add the -o option for export:
-o|--output <pathname>
287 remove '...'
289-292 How about simply:
Sets a property of a service to a specified value.
I'm not exactly sure of the intended meaning of the second sentence, but I doubt
it would apply to all properties.
This is what I had (minus the alias portions)- you're welcome to use all or
parts of it.
installadm set-service -o <prop>=<value> <svcname>
Sets a property of a service to a specified value.
-o|--option <prop>=<value>
Specifies the property and value to set.
prop=value can be:
default-manifest=<manifest/script name>
- default-manifest=<manifest/script name>
The default manifest of a service may not have
criteria actively associated with it while it is
the default. If one uses installadm set-service
to make a manifest the default, then its
associated criteria become "inactive", and are
not considered during manifest selection.
Inactive criteria are clearly indicated by the
installadm list command. If a different manifest
is later made the default, the criteria of the
formerly default manifest becomes active again.
<svcname>
Required: Specifies the name of the installation
service whose property is being set.
346-358 If you are going to add this level of detail for -m, you should also add
it for -p.
424 Change inst_name to man_name
433 refered (typo)
443 not your changes, but please remove extra '-c' inside of <>
461 Use "ignored" instead of "inactive", since that is how it is described
elsewhere and in the list output
471-472 How about: Any associated criteria or default status remain with the
manifest following the update.
474-483 I don't understand this wrt how update-manifest works. I thought that
update-manifest updates the contents of a given manifest, specified by the
required -m option. I didn't think the name would change. We discussed this
offline and you're looking into it, but I think this section should probably be
removed and -m should be required (small code change)
495 per above, this should likely be Required, not Optional
622 usage should match actual usage (different order of options, usage has
<output>, not <output_pathname> )
642 <output_pathname> again
636 It is confusing to mention profiles as part of -m text and to mention
manifests as part of line 652 text. Maybe you can remove the "Any number of..."
text from both -m and -p and add it the general description.
646 need space after comma
963 - Check with Alta if this is the name to use.
971 your installadm add-manifest command is missing the "-n service_092910"
1182 stored in the file -> stored in the files
1206 install the changes -> then update the manifest in svc2
1211 remove "with you favorite editor"
1214 Remove backslash
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
