On 06/08/11 16:31, Dermot McCluskey wrote:
Looks fine, Matt, except I find this comment confusing:
2784 # This is not correct, there may be other pools here just not
2785 # the root pool, so we need to get the root pool specifically
2786 zpools = logical.get_children(class_type=Zpool)
what is not correct? The old code that is being replaced?
Yep, my bad, I was typing what I was thinking when doing this will
change to :
# There may be more than one pool in this logical, so need to iterate
# over all pools and break on root pool.
ok ?
cheers
Matt
- dermot
On 06/08/11 16:15, Darren Kenny wrote:
Looks good to me Matt.
Darren.
On 08/06/2011 15:56, Matt Keenan wrote:
Hi,
Can I get code review for :
7050875 Cannot create a swap slice in CUD/AI
http://monaco.sfbay.sun.com/detail.jsf?cr=7050875
Webrev:
http://cr.opensolaris.org/~mattman/bug-7050875/
CUD/AI was validating that all slices had to be identifiable e.g. belong
to a pool. This is not really valid and a little too strict.
Validation should be to just ensure that in root pool at least one slice
is identifiable as part of the root pool. This fix address this issue
and few others noted in the evaluation that were found on the way.
All auto-install tests pass on both sparc and x86.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
