On 06/08/11 12:48, Darren Kenny wrote:
Why do you think that?
in_be filesystem are created by the call to the C libbe::be_init() not
by install_target code. Our passage to that is via:
install_target/instantiation.py::create_logicals() which at line
344 calls
install_taget/logical.py::BE.init() which at line 910 calls
install_target/libbe/be.py::be_init()
If you look at the be_init() method, it needs to be passed the dataset
properties in a dictionary so that it can then put it into an nvlist to
pass to the C libbe::be_init().
-ethan
in_be is just a flag on a Filesystem object. So whether it's in the BE or not
shouldn't be relevant to this change.
Is it that you'd like me to add a test to validate this?
Thanks,
Darren.
On 08/06/2011 20:31, Ethan Quach wrote:
Hi Darren,
I haven't reviewed your webrev yet, but these changes don't seem to fix
dataset options for in_be filesystems? Is that going to be a separate
bugfix?
thanks,
-ethan
On 06/08/11 10:45, Darren Kenny wrote:
Hi,
I'd like to ask if someone could please provide a code review of the fix for the
bug:
7052475 - need to process dataset options from the AI manifest
[http://monaco.us.oracle.com/detail.jsf?cr=7052475]
The webrev is at:
http://cr.opensolaris.org/~dkenny/bug_7052475/
The issue here was that we we're incorrectly handling the dataset_options and
pool_options tags, assuming that they followed the same style as
filesystem/options tags where the options were brought in to be an attribute of
the Filesystem data object.
This fixes this, and I've added tests to ensure the data is being passed through
the target selection code as expected.
I also updated the tests slightly to refer to a pool "mydata" instead of "data"
which exists on indiana-build and causes failures.
Thanks,
Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
