Hi Kristina, Overall I think this looks really good. I don't really have any substantial comments just a couple of nits and questions. Also I didn't spend much time on the tests...
conv.py: Is __create_any_boot_disk() really needed it doesn't appear to do anything? 1041 # AI doesn't provide with the ability that says initialize remove "with"? 1087 # different in this go around and we are only support change "support" to "supporting"? Can lines 1249 through 1257 be removed? Other than these few minor issues it looks good to me. -evan On Jun 6, 2011, at 8:01 AM, Kristina Tripp wrote: > I still need at least two volunteers to do a review for the following. I'm > out of the office next week Jun 9th and 10th so I'd appreciate getting this > into the tree before then. The webrev has been updated to reflect a change > from the tech writer that js2ai(1) be moved to js2ai(1m). > > Webrev > http://cr.opensolaris.org/~enpointe/cr_7021883/ > > 7021883 js2ai needs to be updated to work with the new target DTD > 7040753 js2ai specifying -p with long path name failure > 7044397 js2ai update to support SC Profile changes made in svn_164 > 7050992 js2ai move man page from js2ai(1) to js2ai(1m) > > > Testing: > Most of the testing for this product still relies on the unit tests and > running against some known jumpstart configuration profiles and ensuring the > converted profiles have no validation errors. The unit test code coverage is > 80%+ for all files. > > There is still a need to test js2ai by running it against some Jumpstart > profiles and doing some installs based on the files created by js2ai. > However, I haven't been able to get a AI Server running with all the proper > bits so this work will need to occur at a latter time period. > -- > <graphics1.gif> > Kristina Tripp, Senior Software Engineer > Oracle Revenue Product Engineering > 500 Eldorado Blvd, MS UBRM05-171 > Broomfield, CO, 80021 > Office: 303-272-8655 > Email: [email protected] > > Oracle is committed to developing practices and products that help protect > the environment > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
