Hi Niall,
Line 669-701: I do not think this is a good place for this code.
The BootMenu class is used by all the installers and DC.
The logic in 669-701 is only needed by the installers. It's definitely
not needed by DC. It would be better to have the logic to
determine whether an alternate boot title is necessary in the
SystemBootMenu class.
Another concern I have is that I do not think the Boot checkpoint should
be the one determining where's the .image_file based on whether we
are net booted or media booted. That logic should be in the installers.
The installers should read the .image_file, get the special grub title
information
and store it somewhere. Then, boot checkpoint will read the special title,
if it is stored by the installer, and put it into the grub menu.
Thanks,
--Karen
On 06/ 9/11 10:31 PM, Niall Power wrote:
Hi,
I'd like to get a review of my fixes for the following bugs:
http://monaco.sfbay.sun.com/detail.jsf?cr=7047882
- Incorrect grub menu entry during reboot after text installation
http://monaco.sfbay.sun.com/detail.jsf?cr=7050300
- Boot from Hard Disk grub entry on X86 ISO media has wrong parameters
Webrev is located at:
http://cr.opensolaris.org/~niall/webrev-7047882-7050300/
Thanks,
Niall
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
