Looks great Darren.

Thanks!

-Drew

On 6/13/11 8:29 AM, Darren Kenny wrote:
On 13/06/2011 15:03, Drew Fisher wrote:
Darren,

Looks good to me.  The only thing you may want to consider is changing
the zpool name to something that is very unlikely to exist in the real
world like "ai_test_datapool" or something very obvious as to its source
and usage.
OK, I did that, but now the change "looks" more complex, but really it's mainly
just formatting due to the now longer lines.

And while at it, did the same for root pools where we use a similar name.

This time, I also modified the SPARC test to match this.

Thanks,

Darren.

-Drew

On 6/13/11 7:47 AM, Darren Kenny wrote:
Hi,

Could I please get a quick review of the changes to the X86 AI Target Selection
tests to resolve 4 failures on indiana-build.

The webrev is at:

        http://cr.opensolaris.org/~dkenny/bug_7052701/

The problem is that that the zpool "data" already exists in indiana-build, as
such it cause the tests to fail.

Thanks,

Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to