Since I have already done the code review and had some off line
discussions, I okay this. Note that I skipped the unit test files. So
we need another reviewer to cover those.
-Sanjay
On 06/14/11 11:28 AM, Drew Fisher wrote:
Good morning!
Could I please get a code review of the following CR:
7020411 <http://monaco.us.oracle.com/detail.jsf?cr=7020411> support in
TD/TI for interfaces that provide CRO information in libdevinfo
http://cr.opensolaris.org/~drewfish/cr_7020411/
Background:
----------
In snv_166, Solaris gained topology knowledge of chassis, receptacles
and occupants called 'CRO' [1]. This webrev gives Install
technologies the ability to leverage this information in order to
provide an additional identification method of disks available during
installation. It is important to know that croinfo returns the disks
in they order they are enumerated by Solaris. This means the first
'SYS' Alias ('SYS' is the label for internal drives) is the first
enumerated internal disk.
Sample output from the command looks like this:
# /usr/sbin/croinfo -o cAR
c:occupant-compdev A:alias-id R:receptacle-name
------------------ ---------- -----------------
c8t0d0 SYS SYS/HD0
c8t1d0 SYS SYS/HD1
c8t2d0 SYS SYS/HD2
c8t3d0 SYS SYS/HD3
(croinfo has many additional flags. If you'd like to play around with
croinfo, feel free to use leeroy.us.oracle.com)
-------
The changes give us the ability to specify a chassis Alias (in this
case, 'SYS') or the receptacle name (such as "SYS/HD2") in the <disk>
element of the AI manifest:
<disk whole_disk="true">
<disk_prop dev_chassis="SYS"/>
</disk>
or
<disk whole_disk="true">
<disk_name name="SYS/HD2" name_type="receptacle"/>
</disk>
The target_selection.py checkpoint has been enhanced to cover these
additional identification methods.
NOTE: When the dev_chassis disk_prop is used, AI will default to the
first entry in the croinfo output for that Alias. If users need finer
control, they can use the receptacle of the disk instead.
Not all systems have the ability to report croinfo output. If a user
tries to specify croinfo <disk> entries, AI will correctly report an
error to the user indicating why AI couldn't find the disk.
I have an AI ISO located here (b167 based):
/net/leeroy.us.oracle.com/rpool/dc/cr_7020411/ai/media/AI_croinfo.iso
(If anybody does any additional testing with the ISO, be aware of CR
7054342)
If anybody has any questions, please let me know.
-Drew
[1] http://sac.sfbay/PSARC/2011/192/
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
