Darren,
The changes look fine to me.
thanks,
-ethan
On 06/16/11 09:20, Darren Kenny wrote:
Hi,
Could I please get a code review for the P1 bug:
7054112 AI install doesn't fail as expected given an manifest without
DOCTYPE specified.
The webrev is at:
http://cr.opensolaris.org/~dkenny/bug_7054112/
The basic problem is that the user didn't have an XML manifest with the
appropriate DOCTYPE specified, this caused the XML to not have the correct
defaults loaded, which in turn caused other issues later since it was assumed
that things like the transfer type would always be present.
The resolution is to enforce the specification of the DOCTYPE in the XML and
also to ensure that we handle an cases where it might get past more correctly.
Thanks,
Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
