LGTM.

- Dermot


On 06/21/11 12:00 PM, Darren Kenny wrote:
Hi,

Could I please get a quick code review of the small fix for bug:

     7057303 Transfer is adding spurious P5ISpec causing zones install to fail

the webrev is at:

        http://cr.opensolaris.org/~dkenny/bug_7057303/

The problem is that the P5ISpec.can_handle() method is incorrectly handling all
software_data nodes, causing some strange behaviour.

It was exposed by another fix I made before where I caused AI to fail if it came
across a transfer type that it couldn't handle - in this case it caught the fact
that it was an IPS transfer, with a P5ISpec as opposed to a IPSSpec.

Thanks,

Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to