|
Someone needs to step up and take ownership on a regular basis
to help review this code
base. I don't like feeling like the work I'm doing for this team
is unappreciated.
Code changes for
7054528 js2ai is generating <partition> for all architectures
7054569 jsai update timezone generate to agree with manifest changes introduced by CR7043012
7055561 js2ai not handling partition default properly
7055710 js2ai update sc_profile translation for hostname
7056207 mixing pool and usedisk keyword results in slice referencing wrong root pool name
The primary change here deals how the manifest file is outputted when a <disk> structure is handled when a Jumpstart profile is processed. Previously we always outputted our structure with a <partition>
<disk> <disk_name name="c1t0d0" name_type="ctd"/> <partition action="" name="1" part_type="191"> <slice action="" in_vdev="rpool_vdev" in_zpool="test" name="0"/> </partition> </disk>
and outputted the manifest file as ${profile_name}.xml
Since partition is not a valid structure for SPARC. This basic design needed to be reworked to pay attention to the architecture that the profile represents. The new profile name form is ${profile_name}.${arch}.xml where ${arch} is "generic", "x86", or "sparc". A generic profile is a profile that has no architectural specific elements located within it, where x86 and sparc are aimed at those architectures. When a Jumpstart profile is processed the architecture for that profile is initially set to GENERIC. If a x86 or Sparc keyword is processed the architecture is updated to reflect that architecture. If the architecture is GENERIC and we process a keyword operation that requires a disk structure to be created, the architecture for the profile is set to None. Internally we then process the profile as an x86 profile. Upon the completion of the profile processing the None architecture v
alue tells us that we need to fetch and generate 2 manifest files for the profile via fetch_tree(arch) in conv.py. Since internally the profile is keep as a x86 profile when the architecture is None, to retrieve a sparc version, the profile is simply modified to remove the <partition> nodes from the profile.
Other changes 7054569 and 55710 are simple to update the xml outputted for the SC Profile to conform to xml changes that have occurred to since the code for these routines was first coded.
Unit test pass no pep8 errors
--
Kristina
Tripp, Senior Software Engineer
Oracle
Revenue Product Engineering
500 Eldorado Blvd, MS UBRM05-171
Broomfield, CO, 80021
Office: 303-272-8655
Email: [email protected]
Oracle is committed to developing practices and
products that help protect the environment
|
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
