Keith and Drew,
I have updated the code to use Popen([FIREFOX, self.show_url]). The
updated webrevs at:
http://cr.opensolaris.org/~johnfisc/url_hang-2
http://cr.opensolaris.org/~johnfisc/url_hang-2-diff
I have tested this within the gui-installer and firefox comes up without
the UI hanging.
Thanks,
John
On 06/25/11 09:44 AM, Keith Mitchell wrote:
Could also use Popen() instead of Popen.check_call() - Popen() will
open the subprocess in a non-blocking manner.
- Keith
On Sat, Jun 25, 2011 at 6:56 AM, Drew Fisher <[email protected]
<mailto:[email protected]>> wrote:
John,
usr/src/cmd/gui-install/src/progress_screen.py
-----------------------------------------
434-435: Can we make a FIREFOX global at the top of the file that
points to '/usr/bin/firefox' and then we can just do:
Popen.check_call([FIREFOX, self.show_url], check_result=Popen.ANY)
on line 436
Otherwise, this looks good.
-Drew
On 6/24/11 9:15 PM, John Fischer wrote:
All,
Mary asked that I clean up several pep8 issues as well. The
updated webrev located at:
http://cr.opensolaris.org/~johnfisc/url_hang
<http://cr.opensolaris.org/%7Ejohnfisc/url_hang>
also has the pep8 issues resolved.
Thanks,
John
On 06/24/11 07:35 PM, John Fischer wrote:
All,
Please review the following webrev:
http://cr.opensolaris.org/~johnfisc/url_hang
<http://cr.opensolaris.org/%7Ejohnfisc/url_hang>
It solves the issue documented by CR 7059258:
http://monaco.us.oracle.com/detail.jsf?cr=7059258
7059258 gui-install hangs while a URL is opened from an
clicking on an image
On the progress_screen if the image has a URL associated
with it
and a user clicks the image then the screen updates will
stop until
firefox is fully started and responds to the click. The
install continues
but the GUI is not updated. This is obviously highly
undesirable.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
<mailto:[email protected]>
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
<mailto:[email protected]>
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected] <mailto:[email protected]>
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
--
Join me in the fight to end AIDS!
http://www.tofighthiv.org/goto/kemitche
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
