Matt,
Looks good. Just one nit:
1360 raise SelectionError(\
1361 "Vdev '%s' on zpool '%s' must contain at least one "
1362 "device." % (child.name, zpool.name))
Back-slash not needed on 1360. No need to re-spin webrev.
- Dermot
On 07/ 8/11 05:00 PM, Matt Keenan wrote:
Hi,
Can I get a review for bug :
7063283 Unable to create UFS swap via AI Install. Tries to
associate swap with zpool
http://monaco.sfbay.sun.com/detail.jsf?cr=7063283
Webrev:
https://cr.opensolaris.org/action/browse/caiman/mattman/7063283
TargetSelection had logic to ensure at least one slice has zpool
identification contained therein, and if not it set the first large
slice it found to the root pool, regardless of whether this slice is
to be used for swap or not.
It should only do this for non swap slices, ensure that if a user
wants to create a UFS swap slice they can.
This is only an issue where the swap slice is being created on a
separate disk on it's own.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
