Yeah, it's my fault, too much team alcohol :-)
Dave (brevity or typos may be blamed on the iPhone) On Jul 8, 2011, at 4:47 PM, Drew Fisher <[email protected]> wrote: > I agree that we should have caught this before pushing but I think we were > all too busy drinking in the hotel lobby bar (this was pushed during > work-week). > > Thanks for the quick review! > > -Drew > > On 7/8/11 2:42 PM, Jesse Butler wrote: >> >> >> I'm guessing whomever integrated the change that caused this didn't run the >> tests prior to pushing? We really should put the "run tests per integration" >> requirement on this side of the push, rather than once the changeset is >> integrated. >> >> Anyhow, looks good. >> >> /jb >> >> On Jul 8, 2011, at 4:32 PM, Drew Fisher wrote: >> >>> Good afternoon! >>> >>> Could I please get a quick code review for: >>> >>> 7044109 New slim_unit_test failures after TI_CUD putback >>> >>> https://cr.opensolaris.org/action/browse/caiman/drewfish/7044109/webrev/ >>> >>> Naturally, the tests run clean now and are also pep8 clean. >>> >>> -Drew >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
