Thanks Karen,
I'll change "s/Creation/Addition" in the debug message.
cheers
Matt
On 07/08/11 18:09, Karen Tung wrote:
Hi Matt,
I reviewed "take four" of the webrev.
All my concerns regarding the text installer and gui installer are fixed.
The only nit I have at this point is:
usr/src/lib/install_target/varshared.py, line 225
That's the debugging message I was referring to in my previous comments
about it not being accurate, since we are not really creating the var
share
dataset here, we are just adding them to the desired target.
Thanks,
--Karen
On 07/ 8/11 07:08 AM, Matt Keenan wrote:
Take Four available with updated varshare.py comments as pointed out
by dave.
https://cr.opensolaris.org/action/browse/caiman/mattman/7048015.7049157.7049160.4
cheers
Matt
On 07/08/11 11:57, Matt Keenan wrote:
New webrev posted :
https://cr.opensolaris.org/action/browse/caiman/mattman/7048015.7049157.7049160.3
This webrev now raises exception of a zvol or filesystem exists in
the desired tree with either name "var" or "shared" or with the
mountpoints "/var" or "/var/shared".
cheers
Matt
On 07/07/11 15:31, Matt Keenan wrote:
Hi,
Can I get a code review for bugs :
7048015 Automated Installer should create a separate /var and
shared area
7049157 Text installer should create a separate /var and shared area
7049160 GUI installer should create a separate /var and shared area
http://monaco.sfbay.sun.com/detail.jsf?cr=7048015
Webrev :
https://cr.opensolaris.org/action/browse/caiman/mattman/7048015.7049157.7049160
All three installers need to create /var within the installed BE
and /var/shared globally available. This is achieved by adding two
Filesystem objects to the DESIRED root Zpool object before Target
Instantiation is called. TI will then simply create them.
A new checkpoint "VarSharedDataset" is being created to handle the
additions, and will be called by all three installers.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
