Fixed, thanks Drew. I've not updated the webrev though...
Darren. On 12/07/2011 15:46, Drew Fisher wrote: > Darren, > > ai_manifest.xml: > > 201: s/be/by > > Otherwise, this looks fine to me. > > -Drew > > > >> Hi, >> >> Could I please get a code review for the fix to bug: >> >> 7060689 CUD/AI fails when facets specified >> 7060691 CUD/AI's default manifest should be easier to customize for >> facets >> >> The webrev is at: >> >> https://cr.opensolaris.org/action/browse/caiman/dkenny/7060689_7060691/ >> >> The problem was that until now we didn't expect anyone to specify a >> destination >> in the ai.xml file. >> >> But, this is how facets are specified in the XML, as such we need to be able >> to >> allow for it, and merge in our desired Image root dir should there be a >> destination in the XML. >> >> This change basically allows for this to happen now. >> >> The fix for 7060691 is to provide an example of how this is done in the >> ai_manifest.xml file. >> >> Thanks, >> >> Darren. >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
