Looks good now,
Thanks,
Darren.
On 13/07/2011 12:21, Nirmal Agarwal wrote:
> Hi Darren
>
> On 07/13/11 16:40, Darren Kenny wrote:
>> Hi Nirmal,
>>
>> I think that strip('"\n\t') is not enough, and probably should include space
>> as
>> well, i.e. be strip('"\n\t ').
>>
>> What do you think?
> Thanks for pointing it out. I have updated the webrev.
>
> Regards
> Nirmal
>>
>> Darren.
>>
>> On 13/07/2011 10:46, Nirmal Agarwal wrote:
>>> Hi all
>>>
>>> Could I please get a code review for the following CR :
>>>
>>> 7060813 AI Installer not parsing pkg between<name> tag properly. Causes
>>> install to fail
>>>
>>> Webrev: https://cr.opensolaris.org/action/browse/caiman/nirmal27/7060813
>>>
>>> I have created a custom image with the fix and used it with the manifest
>>> file in CR. I was successfully able to install.
>>>
>>>
>>> Thanks
>>> Nirmal Agarwal
>>>
>
>
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
