Hi, Could I please get a code review for the following js2ai changes
7062927 js2ai need to delete slices prior to create when user specified whole disk 7063455 js2ai add warning error if hostname and/or root password is not specified in sysidcfg 7066575 filesys update support for swap 7066626 Expand support for usedisk 7066637 js2ai: error: local variable 'processed_data' referenced before assignment. https://cr.opensolaris.org/action/browse/caiman/enpointe/CR_7062927/webrev/ These changes are primarily to address issues discovered when doing live testing last week. As part of filesys swap support work the main __convert_filesys_entry routine was broken out into different routines for handling swap and / filesys entries. This does result in some duplicate logic __convert_filesys_mirror_entry and __convert_filesys_entry But the logic is now much easier to follow and maintain now. Kristina Tripp, Senior Software Engineer Oracle Revenue Product Engineering 500 Eldorado Blvd, MS UBRM05-171 Broomfield, CO, 80021 Office: 303-272-8655 Email: [email protected] Oracle is committed to developing practices and products that help protect the environment
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
