Thanks, Drew.

On 07/19/11 03:56 PM, Drew Fisher wrote:
Dermot,

LGTM!

-Drew

On 7/19/11 8:52 AM, Dermot McCluskey wrote:
Hi,

Can I get a review for this fix, please?

Bug:
7068118
system after gui-install seems to lack swap entry in vfstab
http://monaco.sfbay.sun.com/detail.jsf?cr=7068118

Webrev:
https://cr.opensolaris.org/action/browse/caiman/dermot/7068118/webrev_7068118/


gui-install needs to call TargetController.setup_vfstab_for_swap(),
similarly to how TextInstall does.  To do this, we need to save
a reference to the TargetController instantiated in the Disk Screen
and access it from the Progress screen when the install has
completed.

Testing:
Did a full install in a VM, as per the bug description.
Before: "swap -l" on installed system says no swap devices
configured.
After: "swap -l" shows /dev/zvol/dsk/rpool/swap matching the
zpool details.


- Dermot

_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to