Thanks Jesse and Mary!
-Drew
On 7/19/11 11:40 AM, Jesse Butler wrote:
Looks good to me, Drew.
/jb
On Jul 19, 2011, at 1:29 PM, Drew Fisher wrote:
Good morning!
Could I please get a quick code review for the following CRs:
7052573 <http://monaco.us.oracle.com/detail.jsf?cr=7052573> Swap
slice should be checked if already assigned before attempting to add
7068188 <http://monaco.us.oracle.com/detail.jsf?cr=7068188> nosexunit
test failure in solaris_install/target/libnvpair/nvl.py
https://cr.opensolaris.org/action/browse/caiman/drewfish/7052573_7068188/webrev/
For 7052573, I created a quick UFS swap slice and verified that
_create_ufs_swap deletes the swap before trying to add it back, if it
already exists.
I also moved most of the check_call() calls to use the run() partial
object.
7068188 no longer complains about E0602:
[x4600m2-brm-01:libnvpair] > pylint nvl.py | grep E0602
[x4600m2-brm-01:libnvpair] > echo $?
1
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected] <mailto:[email protected]>
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
