Thanks!!
John
On 07/20/11 02:13 PM, Karen Tung wrote:
Hi John,
Everything looks good to me too.
--Karen
On 07/20/11 14:09, Dermot McCluskey wrote:
Hi John,
Thanks. Looks good now.
- Dermot
On 7/20/2011 7:11 PM, John Fischer wrote:
Dermot,
You are correct. I have a new webrev located at:
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7068480-3/
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7068480-diff-3/
The changes are below.
I have tested the changes. The screen only contains the
default [x] picture and proceeds to install.
Thanks,
John
--- old/usr/src/cmd/gui-install/src/progress_screen.py Wed Jul 20
10:52:36 2011
+++ new/usr/src/cmd/gui-install/src/progress_screen.py Wed Jul 20
10:52:36 2011
@@ -116,12 +116,12 @@
if not os.path.exists(path):
path = os.path.join(IMAGE_DIR, 'C')
if not os.path.exists(path):
- path = IMAGE_DIR
+ self.logger.debug("Unable to determine image
directory")
try:
self.urlimage_dictionary =
self.get_urlimage_dictionary(path)
except IOError:
- pass
+ self.urlimage_dictionary = dict()
self.image_index = 0
self.image_pause = False
On 07/20/11 11:02 AM, Dermot McCluskey wrote:
Hi John,
Can you confirm that, when the images aren't found
and the debug message is logged, the install proceeds
normally? It looks to me like it might still traceback, eg
due to self.urlimage_dictionary not being initialized?
- Dermot
On 07/20/11 17:49, John Fischer wrote:
Karen and Dermot,
I have an updated version of the webrev located at:
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7068480-2/
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7068480-diff-2/
The only change is to the progress_screen.py file and
is included below. Instead of raising a RuntimeError I
simply log the error.
Thanks,
John
--- old/usr/src/cmd/gui-install/src/progress_screen.py Wed Jul
20 09:36:36 2011
+++ new/usr/src/cmd/gui-install/src/progress_screen.py Wed Jul
20 09:36:36 2011
@@ -116,8 +116,7 @@
if not os.path.exists(path):
path = os.path.join(IMAGE_DIR, 'C')
if not os.path.exists(path):
- raise RuntimeError(_("Internal error") + \
- _(" - unable to determine
image directory"))
+ self.logger.debug("Unable to determine image
directory")
try:
self.urlimage_dictionary =
self.get_urlimage_dictionary(path)
except IOError:
pass
On 07/19/11 02:37 PM, Karen Tung wrote:
Hi John,
I have a question on the changes in progress_screen.py.
I see that you will now raise an error if the image directory is
not found.
I assume the error will terminate the gui installer. Is that
kinda harsh?
I tend to think that even if there's no pretty graphics to look
at during
install time, I can still install.
Thanks,
--Karen
On 07/19/11 01:52 PM, John Fischer wrote:
All (especially Dermot),
Can I get a review for the GUI install image localization CR:
http://monaco.us.oracle.com/detail.jsf?cr=7068480
7068480 GUI install image localization directories need to be
setup to allow for localized images
The webrev is located at:
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7068480/
Basically this is a build and directory layout change. The fix
creates a new image C locale directory within slim_source
and updates the build to use it. The thought is that when
the various other localized images are created then the
integration would be to create an appropriate locale
directory and update the build environment to use the
new directory.
This also includes a slight change to the loading of the image
files. Instead of falling back to the older directory structure it
now raises an error instead.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
