Good afternoon!

Could I please get a code review for the following:

7068381 <http://monaco.us.oracle.com/detail.jsf?cr=7068381> AI doesn't retry to list the iscsi target if the OS Device Name is not available 7046878 <http://monaco.us.oracle.com/detail.jsf?cr=7046878> iSCSI not working in targets code

https://cr.opensolaris.org/action/browse/caiman/drewfish/iscsi/webrev/


The problem with 7068381 is that we were not giving the system enough time to configure iscsi before proceeding to trying to list what the shares were. The fix here is to run devfsadm to wait for the devices to configure.


7046878 is a much larger fix which required a minor change to the target.dtd. The change to the dtd allows the target_name to be optional (where it used to be required). This allows the user to specify something that looks like this:

<disk>
<iscsi>
<ip>10.83.220.100</ip>
</iscsi>
</disk>

Which allows iscsi to use sendtargets (a sort of broadcast of all available shares) to tell the initiator which shares are available at that IP.

We now have full LUN support as well. If an iscsi share has multiple LUNs configured, the user will be required to specify which LUN they want to use in the manifest:

<disk>
<iscsi target_lun="0">
<ip>10.83.220.100</ip>
</iscsi>
</disk>

If a share comes back with more than 1 LUN and the user does NOT specify which one they want, we raise an exception. We also raise an exception if the LUN number is invalid (e.g. the user specifies target_lun="5" and there's not a LUN #5 in the share).

Static configurations are also fully supported and the user can specify which target_name they want:

<disk>
<iscsi target_name="iqn.1986-03.com.sun:02:659ae648-921a-43cf-a888-bb98a5d6a6b6" target_lun="0">
<ip>10.83.220.100</ip>
</iscsi>
</disk>



If anybody has any questions or would like the x86 AI ISO I created to play around with, please let me know.

Thanks!

-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to