Hi Sue,
Thank you for the review. Please see my response inline.
On 07/21/11 12:27, Sue Sohn wrote:
On 07/20/11 11:42 PM, Karen Tung wrote:
Please review my changes for the following 2 bugs:
6985652 <http://monaco.us.oracle.com/detail.jsf?cr=6985652> changes
in text installer iso image for safe provision of localization
without garbled display
7068464 <http://monaco.us.oracle.com/detail.jsf?cr=7068464>
determine_terminal_type() function in sysconfig.profile.system_info
doesn't work in some cases
webrev:
https://cr.opensolaris.org/action/browse/caiman/ktung/locale_bugs/webrev/
Takeshi from the localization team tested and verified the changes
work as expected.
The changes made to network_info.py is not related to these 2 bugs.
It's a couple
of pep8 errors that I saw and fixed.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Karen,
system-config/__init__.py
49 Determining -> Determine
56 If the this program is -> If
58 ditto
Also, not your changes, but gettext is imported twice
All the items above are fixed.
Makefile
23 Need to update copyright
Also fixed.
text-install/__init__.py
52-55 It looks like you commented out 52-53 for testing. Do you need
to uncomment 52-53 and remove 54-55?
302-303 Same here, one of these lines should be removed
Yep, Niall pointed these out as well. I have removed my
debugging/testing statements.
Thanks,
--Karen
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
