LGTM as well. Thanks for addressing this in time, Drew.
Martin
On 7/26/2011 9:20 AM, Dave Miner wrote:
Fix looks fine. Agreed that this should go into 171 if we haven't delivered
yet.
Dave
On 07/26/11 12:07, Drew Fisher wrote:
Good morning!
Could I get a quick 2 line code review for :
http://monaco.sfbay.sun.com/detail.jsf?cr=7071194
7071194 AttributeError: 'NoneType' object has no attribute 'devpath'
The fix here is to simply remove the logging lines:
diff -r 3ac3e7cef10c -r fddeff8546e8 usr/src/lib/install_target/discovery.py
--- a/usr/src/lib/install_target/discovery.py Mon Jul 25 14:31:38 2011
+0100
+++ b/usr/src/lib/install_target/discovery.py Tue Jul 26 10:02:55 2011
-0600
@@ -605,8 +605,6 @@
di_props = list()
if const.DI_FLOPPY in di_props:
- self.logger.debug("skipping USB drive at: "
- "%s" % new_disk.devpath)
continue
I decided to just remove the logging lines because the device we're
trying to skip could be any number of things that may or may not have:
a devpath, a ctd, a devid, or any of the three. Since we're mostly
dealing with virtual drives via the ilom interface, there's no need to
save the identifying string of the drive.
Mary: Since this is ultra low-risk for gate issues, I'd really like to
try to get this into 171 if at all possible.
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
