Thank you very much for review, Ginnie.
Please see my response in line.
Jan
On 07/26/11 10:25 PM, Virginia Wray wrote:
Hi Jan --
Here are my comments:
pre_pkg_img_mod.py
-----------------------------
line 450: Why was "etc/system" removed from the save list?
During testing I have noticed that the whole manipulation of etc/system
is taken care
in modify_etc_system() method - it
* copies original etc/system to the save area
* modifies etc/system to serve install media purposes
So saving it separately by calling save_files_directories() method is
not needed
and in fact is not the desired thing to do, since
save_files_directories() moves
original files to the save area (does not preserve source files) while
we want
etc/system file preserved for purposes of later modification in
modify_etc_system()
method.
set_lang
---------------
How is the default lang set? I assume it occurs in smf; just curious
more than anything.
yep, that is correct. smf manifest of environment smf service delivers
default
values for LC_* and LANG variables:
...
<property_group name='environment' type='application'>
<propval name='LC_ALL' type='astring'
value='C' />
<propval name='LANG' type='astring'
value='C' />
<propval name='LC_CTYPE' type='astring'
value='C' />
<propval name='LC_NUMERIC' type='astring'
value='C' />
<propval name='LC_TIME' type='astring'
value='C' />
<propval name='LC_COLLATE' type='astring'
value='C' />
<propval name='LC_MONETARY' type='astring'
value='C' />
<propval name='LC_MESSAGES' type='astring'
value='C' />
<propval name='TZ' type='astring'
value="localtime" />
<propval name='value_authorization' type='astring'
value='solaris.smf.value.environment' />
</property_group>
...
system-config/__init__.py
---------------------------------
line 865: the man page shows
-c config_profile.xml |dir
instead of
-c profile | dir
we should be consistent with the man page.
I agree. I will change that.
Other than that, it looks good.
Thanks again !
Thanks,
ginnie
On 07/26/11 10:19 AM, Jan Damborsky wrote:
Hi Ginnie,
could I please ask you to review fixes for following SC bugs ?
7061367 Install technologies should benefit from PSARC/2011/097 for
purposes of locale(5) configuration
7068682 sysconfig(1m) Usage message incomplete: [-c profile] should
be [-c profile | dir]
7064593 "sysconfig configure -c <dir>" should fail if <dir> is empty
7068646 sysconfig(1m) should refuse SC profiles without .xml suffix
6997850 Stop populating hosts(4) file once CR 6996436 is addressed
7071116 terminal type does not reflect configuration in SC profile
7068462 slim unit test failures after sysconfig putback
7069484 pep8 errors in sysconfig/__init__.py
7065611 Add locale support to sc profile
webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/sc-bugs/webrev-0726/
As usual, other comments are more than welcome :-)
I would appreciate if comments could be provided before 7/28 Th COB,
so that these changes can appear in 172 (I am ooto next week).
Thank you very much,
Jan
testing done:
* built LiveCD and Sparc TI ISOs with modified Distro Constructor
containing all changes
- 7061367 - during LiveCD boot, selected Spanish on text language
screen - verified that LiveCD
desktop came up in Spanish and that installed system came up
with es_ES.UTF-8 configured as default
locale.
- verified with Sparc text installer that selected locale
(en_US.UTF-8) was correctly
configured on installed system.
- 6997850 - verified that loopback address is associated with
correct hostname in hosts(4)
file on install media as well as on installed system
- 7071116 - verified that terminal type is correctly configured on
installed system
* process of building other install media is still in progress -
will be tested before push
* ran sysconfig CLI in different scenarios to verify fixes for
7068682, 7064593, 7068646
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
