I have gone though the review again and its LGTM.
-Sanjay
On 08/ 1/11 10:36 PM, Dave Miner wrote:
On 07/28/11 02:49 PM, Dave Miner wrote:
On 07/28/11 13:55, Virginia Wray wrote:
Hi Dave --
Here you go...
Makefile.buildnum
-----------------------
ln 107: small typo:
for the finding the values/for finding the values
Accepted.
sc_template.xml
---------------------
ln 65 - 73:
nwam is obsolete now...this could use an update
Actually, I suspect I should have deleted this file, as I believe this
was an artifact of the old GUI, not the CUD implementation. I'll look
into that further.
I've removed this and verified that the live CD continues to install
correctly.
Also, there's been a slight change to the package versioning
requirements that's reflected in usr/src/Makefile.buildnum.
New webrevs, Full:
https://cr.opensolaris.org/action/browse/caiman/dminer/slim_cleanup/webrev/
Incremental vs. first review:
https://cr.opensolaris.org/action/browse/caiman/dminer/slim_cleanup_1-2/webrev
Thanks,
Dave
terminalui/Makefile
-----------------------
You removed clean, but clobber still has clean...
Just wondering...how does this work? Is this picked up somewhere else?
lib/Makefile.targ has a clean target that covers a variety of objects,
the CLEANFILES definition I added here puts the .pyc's into that list
and just uses that rule. The current code causes make to emit warnings
about duplicate clean rules.
Dave
Thanks,
ginnie
On 07/28/11 09:55 AM, Dave Miner wrote:
I need reviewers for the relatively large webrev at:
https://cr.opensolaris.org/action/browse/caiman/dminer/slim_cleanup/webrev/
The bugs covered here are:
7053542 Need to do slim_source clean up after conversion to CUD
7066363 Implement Install pkg versioning scheme for S11
7067202 live-io-tracing needs update for DTT move
While large, this is mostly taking out the trash (60000 lines worth)
that we piled up over the course of moving all the apps to CUD.
The significant change is to the package versioning scheme, which
grows some extra digits in preparation for S11 updates and SRU's.
Finally, the iotracing stuff that we use for optimizing the live CD
needed updating due to the new location of the DTraceToolkit. Also
found a couple bugs there that meant it wasn't fully operational even
before this, we just hadn't noticed.
I've built all the forms of media and successfully installed them.
Also ran an AI server with these bits as the server for my test AI
installs.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
