Niall and Seth:
LGTM. I had also compiled new packages and run the slim_install_unit
tests, pep8 and nosexunit tests and they are fine.
Thanks !!!
On 08/ 3/11 08:02 PM, Niall Power wrote:
Hi,
I'm submitting this code review for Seth since he doesn't have access
to the Caiman subsection of the
opensolaris.org code review tool.
This webrev addresses pep8 and pylint issues noticed causing
nosexunit failures in slim_source plus
a couple of other issues.
Bugids:
7073593 nosexunit test failures after PSARC/2011/250 Boot
Management Interface Contract putback
7073625 pep8 test failures after PSARC/2011/250 Boot Management
Interface Contract putback
7074764 pybootmgmt raises an exception when findroot is used with
no bootfs
7074766 pybootmgmt can add incorrect kernel directives to a menu
entry
Webrev:
https://cr.opensolaris.org/action/browse/caiman/niall/bootmgmt-pep8lint
Thanks,
Niall
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
