Thanks. I fixed that and created a new webrev if anyone wants to take a look.

webrev: https://cr.opensolaris.org/action/browse/caiman/hshaw/7081868_1

Harold

On 08/ 5/11 03:20 PM, Drew Fisher wrote:
Harold,

About the only thing I see is lines 135-144 in svc-install-server appear to be at the wrong indentation level. Otherwise, LGTM.

-Drew

On 8/5/11 3:04 PM, Harold Shaw wrote:
Please review my changes for the following changes:
7066261  <http://monaco.us.oracle.com/detail.jsf?cr=7066261>  Need a way to 
force the migration from /tftpboot to /etc/netboot when upgrading to ISIM
7071868  <http://monaco.us.oracle.com/detail.jsf?cr=7071868>  Default service 
not created if SMF services fail to start

webrev:
https://cr.opensolaris.org/action/browse/caiman/hshaw/7081868/webrev/

I ran the following tests:
- Created an initial service (create default service alias) with nothing in /tftpboot
- Created additional service with nothing in /tftpboot
- Created an alias of an existing service with nothing in /tftpboot
- Created an initial service (create default service alias) with stuff in /tftpboot
- Created additional service with stuff in /tftpboot
- Created an alias of an existing service with stuff in /tftpboot
- Tried enabling install/server manually with stuff in /tftpboot
- Cleared out /tftpboot and created a service to verify that the service would start up clean



_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to