Looks good. /jb On Aug 8, 2011, at 4:20 PM, Drew Fisher wrote:
> Good afternoon! > > Could I please get a code review for: > > http://monaco.sfbay.sun.com/detail.jsf?cr=7076343 > > 7076343 AI fails in snv_172 in the target-discovery phase > > Really simple one line fix: > > diff -r a32740f8fe7d usr/src/lib/install_target/controller.py > --- a/usr/src/lib/install_target/controller.py Mon Aug 08 09:19:05 2011 -0700 > +++ b/usr/src/lib/install_target/controller.py Mon Aug 08 13:52:02 2011 -0600 > @@ -542,7 +542,7 @@ > if disk.label == "VTOC" and not self._dry_run: > # look for this disk in the DISCOVERED target tree to see if the > # label changed from EFI to VTOC > - for discovered_disk in self._discovered_disks: > + for discovered_disk in self.discovered_disks: > if disk.ctd == discovered_disk.ctd: > if discovered_disk.label == "GPT": > # we need to reset the label > > (I removed the "_" character) > > I neglected to use the property and used the variable instead. The property > is there for exactly this reason. Bad Drew. Bad. > > I tested the ISO by both specifying the disk (as PIT did) and by letting AI > pick the disk. Both versions successfully complete target instantiation. > > -Drew > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
