LGTM Drew. --Karen
On 08/08/11 15:14, Drew Fisher wrote: > Good afternoon, > > Since we're dealing with a very tight window for pushing of this fix > to the slim_source gate, I'd like to get a preemptive code review for > the following CRs: > > 7072842 <http://monaco.us.oracle.com/detail.jsf?cr=7072842> update > install gate for pkg5 API version bump to 66 > 7076306 <http://monaco.us.oracle.com/detail.jsf?cr=7076306> slim > source needs a common import for pkg5 API number > > https://cr.opensolaris.org/action/browse/caiman/drewfish/7072842/webrev/ > > Please note that this code will currently *not* work with the pkg5 > gate. They're still on version 65 of the API. I am awaiting Brock's > push of 18439 which will bump their gate to 66. Also, I have the > needed changes to our gate for Brock's push (I will review the code > once he pushes to make sure we don't break anything else, however) and > those prevent zones from installing. > > What I'm saying is: don't try to run this code until 18439 goes back. > > I tested building an AI ISO with DC and installation of that ISO to > make sure our transfer/ips.py code is correct. My ISO was created and > installed with no problems. I also verified that js2ai doesn't break > by running the test suite. Sue helped me test installadm's create a > service from a package and that works as well. > > Thanks! > > -Drew > > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
