On 08/09/11 16:05, Drew Fisher wrote:
Good afternoon!
Could I please get a code review for:
https://cr.opensolaris.org/action/browse/caiman/drewfish/ips66/webrev/
If you looked at yesterday's preemptive review, very little has changed
with the exception of moving the IPS version in
install_common/__init__.py to 66 and the small rewrite of the
get_pkg_list functionality in installadm/image.py based on Shawn's comments.
I ran all the unittests for installadm, js2ai, install_common,
install_ict, and install_transfer. I'm not seeing anything that's not
already being picked up by Hudson (I hope...)
I also confirmed the fix by:
- constructing an AI ISO and installing it completely to a VM guest.
(in progress, but it's past where the code would fail for a version
mismatch).
- creating a zone with the same bits
- testing Sue's image-from-a-package flags to installadm
Once I get a couple of reviews and Mary's blessing to push, I will do so.
Just a nit that I would add a comment in install_common/__init__.py to
note that this is a global API version for all of the API consumers in
the source tree.
Otherwise OK.
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
