That looks good now, Drew.
/jb

On Aug 12, 2011, at 11:25 AM, Drew Fisher wrote:

> Round 3:
> 
> https://cr.opensolaris.org/action/browse/caiman/drewfish/6987307_3/webrev/
> 
> The difference between rounds 2 and 3 are that I added some extra code to try 
> to make the aliases easier ('target' rather than 'install_target')
> 
> Here's the updated --help output
> 
>               group tests
>                       all:  libraries, commands
>                 libraries:  target, utils, doc, logging_pymod, netif, 
> liberrsvc, libict_pymod, ict, terminalui, liberrsvc_pymod, boot, engine, 
> manifest_input, logging, common, manifest, transfer, libaimdns
>                  commands:  distro_const, js2ai, ai-webserver, system-config, 
> system-config/profile, auto-install, auto-install/test, installadm, 
> text-install
> 
>          individual tests
>              ai-webserver:  cmd/ai-webserver/test
>              auto-install:  cmd/auto-install/checkpoints/test
>         auto-install/test:  cmd/auto-install/test
>                      boot:  lib/install_boot/test
>                    common:  lib/install_common/test
>              distro_const:  cmd/distro_const/checkpoints/test
>                       doc:  lib/install_doc/test
>                    engine:  lib/install_engine/test
>                       ict:  lib/install_ict/test
>                installadm:  cmd/installadm/test
>                     js2ai:  cmd/js2ai/modules/test
>                 libaimdns:  lib/libaimdns/test
>                 liberrsvc:  lib/liberrsvc/test
>           liberrsvc_pymod:  lib/liberrsvc_pymod/test
>              libict_pymod:  lib/libict_pymod/test
>                   logging:  lib/install_logging/test
>             logging_pymod:  lib/install_logging_pymod/test
>                  manifest:  lib/install_manifest/test
>            manifest_input:  lib/install_manifest_input/test
>                     netif:  lib/netif/test
>             system-config:  cmd/system-config/test
>     system-config/profile:  cmd/system-config/profile/test
>                    target:  lib/install_target/test
>                terminalui:  lib/terminalui/test
>              text-install:  cmd/text-install/test
>                  transfer:  lib/install_transfer/test
>                     utils:  lib/install_utils/test
> 
> 
> A couple of pairs of eyes on this and I'll push.  Dave's already blessed the 
> push.
> 
> -Drew
> 
> 
> On 8/11/11 9:53 AM, Drew Fisher wrote:
>> 
>> Good morning!
>> 
>> I was hoping to get a quick code review for
>> 
>> 6987307 Update slim_test to allow better granularity of test selection
>> 
>> https://cr.opensolaris.org/action/browse/caiman/drewfish/6987307/webrev/
>> 
>> This impacts none of our packaged code, so I figured it was safe to send out 
>> even though we're in a restricted build phase.
>> 
>> I added a new test script which allows two new things:
>> - the ability to specify subsets of tests to run rather than running every 
>> single test in the gate
>> - regression testing against prior Hudson results.
>> 
>> The regression testing isn't the smartest algorithm so take that testing 
>> with a grain of salt.  By default, the new script looks at the latest Hudson 
>> install_unit_tests job and compares against that.  If somebody pushes 
>> something that breaks 50 tests, that will be used as the baseline.  I added 
>> a flag to the script which allows you to specify which Hudson job you want 
>> to compare against should something like that happen.
>> 
>> The change to tests.nose was to re-include the /lib/install_ict/test 
>> directory.  It went missing at some point ...
>> 
>> Thanks!
>> 
>> -Drew
>> 
>> 
>> _______________________________________________
>> caiman-discuss mailing list
>> [email protected]
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to