Karen, Looks good! Just a few comments and some nits -
general: You seem to make this call: locale.format_string(....) quite a bit. You could create a functools.partial object in text-install/__init__.py for doing this: from functools import partial # locale.format partial object for printing numbers nprint = partial(locale.format_string, "%*.1f") Then, you use it like this: size_field = nprint((len_size, disk_size)) and you can override the default "%*.1f" on the fly: self._size_line = nprint(DiskScreen.SIZE_TEXT, (rec_size, min_size)) disk_selection.py ----------------- 184: extra \ disk_window.py -------------- 361, 362, 810, 839: extra \ 821: why do you need to cast to float? locale.atof should return a float fdisk_partitions.py ------------------- 196, 197: extra \ partition_edit_screen.py ------------------------ 243: extra \ summary.py: ---------- 233, 234, 243, 244, 250, 251: extra \ -Drew On 8/13/11 12:15 AM, Karen Tung wrote:
I would like to get a couple of people to look at the changes for the following bugs: 7077329 <http://monaco.us.oracle.com/detail.jsf?cr=7077329> Problem with install/textui 7069600 <http://monaco.us.oracle.com/detail.jsf?cr=7069600> Size object in solaris_install.target.size doesn't work correctly in none-C locale 7063903 <http://monaco.us.oracle.com/detail.jsf?cr=7063903> [Text Installer] Installation fails for nondefault locale. webrev: https://cr.opensolaris.org/action/browse/caiman/ktung/locale-bugs/webrev/ I built a text installer image with these changes, and I was able to successfully install using C locale, German locale and Japanese locale. Thanks, --Karen _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
