Looks good to me Jack, Thanks,
Darren. On 16/08/2011 01:08, Jack Schwartz wrote: > Hi everyone. > > Here is a fairly simple code review. Can I have two reviewers please? > > https://cr.opensolaris.org/action/browse/caiman/schwartz/7077085_1 > > 7077085 installadm set-criteria takes only one criterion at a time > 7077100 installadm list -p -n should show None when no criteria are > present for a profile > 7078737 aimanifest gives no error msg and does nothing when needed > quotes are missing > > Bug reports are all updated. > http://monaco.us.oracle.com/detail.jsf?cr=7077085 > http://monaco.us.oracle.com/detail.jsf?cr=7077100 > http://monaco.us.oracle.com/detail.jsf?cr=7078737 > > I need to finish testing, but it all looks fine so far. > > Thanks, > Jack > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
