Hi, Anybody willing to review this? I'd really like to get some more eyes on it and get it pushed before the end of the week ;)
Thanks, Darren. On 12/08/2011 18:09, Darren Kenny wrote: > Hi, > > I'd like to request a code review for the bug: > > 7037014 Install DTDs should be versioned > > The webrev is at: > > https://cr.opensolaris.org/action/browse/caiman/dkenny/7037014/webrev/ > > Summary: > > The basic changes that have been made are as follows: > > - Rename all .dtd files to .dtd.1 > > - Add references in install_common to get to these file using > constants. > > - Add a method to check if a give string looks like a .dtd or .dtd.1 > file. > > - Add constants to Makefile.master for the DTD versions, one for each > file. > > - Generate the .dtd.<Version> file at build time, and similarly, any > file that needs a reference to this versioned name. > > For this to work I've added an entry in Makefile.master to do a sed > on any file with a .src suffix. > > The sed replaces any @DTD_VERSION_XX@ type values in the text. > > All .xml files are now named .xml.src. > > - The packaging refers to variables $(DTD_VERSION_XX), which are > replaced as as part of the pkgmogrify. > > - Symlinks exist now for ai.dtd and dc.dtd to their versioned > counterpart. This is to aid migration at this last stage. > > - Attempting to add an XML manifest with a reference to ai.dtd will > generate an error if there is an ai.dtd.1 file also in the install > image. > > Testing done: > > In all my generation of ISOs I've been using the DC in the build I'm > doing, so DC has been well tested. > > Jack did some Derived Manifest testing (Thanks) > > AI installs have been done using various AI servers: > > - snv_151a > - snv_171 > - snv_171 + dtd_versioned bits > > Both SPARC and x86 clients were tested - with the AI clients installing > the ISOs generated from the dtd_versioning workspace and snv_171 ISOs. > > I also verified that an zones install worked too. > > Thanks, > > Darren. _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
