Looks good.
- dermot
On 08/16/11 14:12, Darren Kenny wrote:
Also fixed other pep8 issues found.
Thanks,
Darren.
On 16/08/2011 13:56, Drew Fisher wrote:
Darren,
auto-install.py
-------------
38: change to using splitlines(). Also you have a leading space just
inside the list '[' character
print "\n".join(["%s%s" % (" ", l) for l in str(e).splitlines()])
Otherwise this looks good. No need to respin a webrev for this...
-Drew
On 8/16/11 6:50 AM, Darren Kenny wrote:
Hi,
Could I please get two pairs of eyes on this relatively simple code change to
output the details of a CatalogRefreshException, the bug is:
7057702 AI installer should catch CatalogRefreshException exceptions
and print it's contents on error
I also added code to indent all lines in the error output in auto-install.py,
rather than just the first line.
The webrev is at:
https://cr.opensolaris.org/action/browse/caiman/dkenny/7057702/webrev/
Thanks,
Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
