Hi Matt,
target_selection.py
1202 typo: "beacuse"
Also, you should combine the phrases together.
self.logger.warning("Failed to add default swap zvol to "
"root pool. Possibly beacuse of insufficient space.")
->
self.logger.warning("Failed to add default swap zvol to "
"root pool, possibly because of insufficient space.")
1207 Similarly, combine phrases.
Sue
On 08/16/11 06:48, Matt Keenan wrote:
Hi,
Can I get two pairs of eyes to review relatively simple change for bug :
7077923 - http://monaco.sfbay.sun.com/detail.jsf?cr=7077923
Webrev:
https://cr.opensolaris.org/action/browse/caiman/mattman/7077923/
When creating a number of slices and the slice sizes are not given, Target
Selection will attempt to
determine the size of each slice based on the largest gap available.
If the gap available is less than the min install size an exception was being
thrown, this is fine
if the slice is going to be used for a solaris install, which in quite a few
cases will not be the
case.
Remove the min install size check for both slices and partitions as this
particular check is
actually done later in when the root pool is validated to be large enough to
install to in
__validate_logical().
Added unit test to capture this, and also fixed up other unit tests that had
started to fail post
the swap/dump putback changes done recently.
cheers
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
