As I explained to Darren, we're also missing:

*, /, -=, *=, /=, div, mod, ^=, %=, and all of the rest of the mathematical operations. If we find that we need them for Size objects, they're easy enough to add at that time.

-Drew

On 8/16/11 9:12 AM, Jack Schwartz wrote:
Hi Drew.

Python operator overloading in action!  Neat!

I'm pondering asking about an __isub__() just for symmetry, but being that this class is specialized for our purposes and not in a library, it's OK that it's not there.

LGTM!

    Thanks,
    Jack

On 08/16/11 05:52 AM, Drew Fisher wrote:
Good morning!

Could I please get two pairs of eyes to look at a code review for:

7079464 <http://monaco.us.oracle.com/detail.jsf?cr=7079464> Add math functions to the Size class

https://cr.opensolaris.org/action/browse/caiman/drewfish/7079464/webrev/

Thanks!

-Drew


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to