Darren,
You bring up some good points about what to call the domain name for
NIS/LDAP. This domain name is represented by domainname(1m), which
states that it is "usually referred to as the NIS domain name".
Furthermore, the NIS/LDAP domain name is stored in
network/**nis**/domain. But it can also refer to the domain name for
the LDAP name server, so calling it the "NIS domain name", can be
confusing.
I think it is best to follow the distinction of DNS search list/Domain
name. DNS search list clearly refers to DNS and it is a list, and it
follows the DNS/no DNS selection screen.
Then follows the LDAP/NIS/None selection screen, followed by the "Domain
Name" screen, which clearly states in the instructions that it pertains
to the LDAP and NIS selections. The help file reiterates that distinction.
Made changes accordingly. Tested with various paths in text installer
and SCI tool. Updated webrev.
Responses below:
Michen
On 08/16/11 05:19 PM, Darren Kenny wrote:
Hi William,
In general looks good to me, a couple of minor comments:
- In nameservice_info.py, line 88, I wonder based the bugs if this should read
as "NIS Domain Name" as opposed to just "Domain Name".
Took your suggestion.
- In summary.py, lines 244-245, why do you always output the NIS domain even if
LDAP is the NS that's been selected?
Changed it to say just "Domain Name" and moved it just after Name
Service:NIS/LDAP summary line.
If it is indeed applied to the LDAP NS, then maybe it should be NIS/LDAP
Domain Name as opposed to NIS domain?
There is no such thing as an LDAP domain name, so sticking to simple
"Domain Name".
- In test_nameservice.py, you refer to the domain as ns_domain, should this be
nis_domain?
Hopefully the distinction is clear without the change, since the single
domain entry is for both LDAP and NIS name services.
Thanks,
William
Thanks,
Darren.
On 12/08/2011 13:27, William Schumann wrote:
Domain-related issues for S11 text installer/SCI tool
https://cr.opensolaris.org/action/browse/caiman/wmsch/7077465/webrev/
7077465 Text installer's multiple name service input screens need to be less
confusing
7077490 The "Domain Name" is confusing
7077462 scitool makes erroneous assumption that DNS and NIS domain will be the
same
The above bugs are all solved by using the 'Domain Name' screen only for NIS
domain (which is used for NIS and LDAP), and clearly
labeling 'NIS Domain' in headers, text, and help file.
Screen order now (assuming DNS + NIS or LDAP selected):
DNS/no DNS
DNS server
DNS search list
LDAP/NIS/None (formerly after DNS/no DNS)
NIS Domain Name (formerly Domain Name, went before DNS server)
NIS screens or LDAP screens
7077417 underscore as part of domain name is rejected by sysconfig configure
adding underscores to 2 patterns for domain name validation
7077397 After the install both domain and search appeared in resolv.conf
removed DNS 'domain' - using only 'search'
Tested UI, checking paths for DNS/no DNS, Alternate NS/not, verified help,
checked defaults, reviewed profile output
updated pyunit tests for validation and for profile output
Demo system available (fsh-weakfish.us)
Thank you,
William
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
